Rdkafka runs in its own multiverse group #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
SimpleCov Report
|
fallwith
approved these changes
Oct 11, 2024
kaylareopelle
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this will make rdkafka run in it's own group for now. I named the group just kafka because i'd like to later include both kafka gems in it, but for now, for debugging our weird problems, I want it to only be rdkafka.
I also added the exit code to another string. We do already output the exit code in a different spot, but I wasn't seeing that message actually show up when we see our problem for some reason, so I've added it to a message that I do actually see, so maybe we'll get a little more info out of that.